feat: add standalone shuffle benchmark binary for profiling#3752
Draft
andygrove wants to merge 3 commits intoapache:mainfrom
Draft
feat: add standalone shuffle benchmark binary for profiling#3752andygrove wants to merge 3 commits intoapache:mainfrom
andygrove wants to merge 3 commits intoapache:mainfrom
Conversation
Add a `shuffle_bench` binary that benchmarks shuffle write and read performance independently from Spark, making it easy to profile with tools like `cargo flamegraph`, `perf`, or `instruments`. Supports reading Parquet files (e.g. TPC-H/TPC-DS) or generating synthetic data with configurable schema. Covers different scenarios including compression codecs, partition counts, partitioning schemes, and memory-constrained spilling.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
N/A - new tooling
Rationale for this change
The existing shuffle benchmarks use small synthetic data (8192 rows x 10 batches) with Criterion, which makes it difficult to:
cargo flamegraph,perf, orinstruments(Criterion's harness interferes)What changes are included in this PR?
Adds a
shuffle_benchbinary (native/core/src/bin/shuffle_bench.rs) that benchmarks Comet shuffle write and read performance independently from Spark.Features:
--read-backdecodes all partitions and reports throughputExample usage:
How are these changes tested?
Manually tested with both generated data and various configurations: